jextract: remove unsigned integers mode, remove wrap-guava mode #485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
approved these changes
Dec 8, 2025
Collaborator
ktoso
left a comment
ktoso
left a comment
There was a problem hiding this comment.
lgtm, nice to see code removal, we can always bring it back if we'd need to
| case .wrapGuava: .wrapUnsignedGuava | ||
| } | ||
| } | ||
| } No newline at end of file |
Collaborator
There was a problem hiding this comment.
lgtm on record that yeah i think we can remove this mode; if we'd ever want it back it'll be easy to bring back from past commits
| public func getJNIValue(in environment: JNIEnvironment) -> JNIType { | ||
| // On 32-bit, standard JDK jlong is defined as long long = Int64 | ||
| // On 64-bit, standard JDK jlong is defined as long = Int | ||
| // On Android it's correctly marked as int64_t |
Collaborator
There was a problem hiding this comment.
The comment could be clearer about the "why" this is ok: is it because it is 64bit on all Android versions we're supporting?
Contributor
Author
There was a problem hiding this comment.
I updated the docs, is that better?
Collaborator
There was a problem hiding this comment.
Thanks that makes more sense
ktoso
changed the title
ktoso
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the forums thread, we decided to just use the underlying bit representation of any unsigned integral types. On top of that we then always use the
@Unsignedannotation in JExtract, and remove the unsigned integers mode, since noone is really using wrap-guava.