Add messageformat2_arguments.h to module map #83
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
approved these changes
Oct 22, 2025
itingliu
reviewed
Oct 22, 2025
itingliu
reviewed
Oct 22, 2025
|
@itingliu interesting; it seems that CI is still okay with it? 🤔 |
|
Apologies! this is completely the wrong fix. The issue is we are not packaging the file, not that it is not in the module map. |
|
correct fix up in swiftlang/swift-installer-scripts#473 |
No idea. Perhaps the module map doesn't always get rebuilt? It even passed my full toolchain test (invoked from swiftlang/swift-corelibs-foundation#5277) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#80 added some new files, but module.modulemap is missing
messageformat2_arguments.hso adding it. this is causing build breaks using the resulting module map. see example