-
Notifications
You must be signed in to change notification settings - Fork 216
Added functionality to -register-module-dependency flag #2013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sepy97
wants to merge
1
commit into
swiftlang:main
Choose a base branch
from
sepy97:register-module-dependency_logic
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f12de1f to
dfbfc04
Compare
dfbfc04 to
7c7ec33
Compare
nkcsgexi
reviewed
Nov 12, 2025
7c7ec33 to
d9e38b9
Compare
artemcm
requested changes
Nov 12, 2025
Sources/SwiftDriver/ExplicitModuleBuilds/ModuleDependencyScanning.swift
Outdated
Show resolved
Hide resolved
Sources/SwiftDriver/ExplicitModuleBuilds/ModuleDependencyScanning.swift
Outdated
Show resolved
Hide resolved
d9e38b9 to
17f9a6b
Compare
artemcm
reviewed
Nov 13, 2025
Sources/SwiftDriver/ExplicitModuleBuilds/ModuleDependencyScanning.swift
Outdated
Show resolved
Hide resolved
artemcm
reviewed
Nov 13, 2025
Sources/SwiftDriver/ExplicitModuleBuilds/ModuleDependencyScanning.swift
Outdated
Show resolved
Hide resolved
rdar://164596852 This flag tells the driver to include the module in the dependency scanning, but not load it. Added test case for the flag.
17f9a6b to
9c866f6
Compare
artemcm
approved these changes
Nov 13, 2025
Contributor
artemcm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Contributor
|
@swift-ci test |
nkcsgexi
approved these changes
Nov 14, 2025
Contributor
|
@swift-ci test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rdar://164596852
This flag tells the driver to include the module in the dependency scanning, but not load it. Added test for the flag.