🍒 [lldb][DWARFASTParserClang] Treat DW_TAG_template_alias like we do DW_TAG_typedef #11918
+348
−174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ort (llvm#170249) We almost had RTTI support for `DWARFASTParserClang`, but because `classof` was protected, using `llvm::cast`/etc. on it would fail to compile with: ``` llvm/include/llvm/Support/Casting.h:64:57: error: 'classof' is a protected member of 'DWARFASTParserClang' 64 | static inline bool doit(const From &Val) { return To::classof(&Val); } | ^ llvm/include/llvm/Support/Casting.h:110:32: note: in instantiation of member function 'llvm::isa_impl<DWARFASTParserClang, lldb_private::plugin::dwarf::DWARFASTParser>::doit' requested here 110 | return isa_impl<To, From>::doit(*Val); ``` This patch makes `classof` public and turns `static_cast`s of `DWARFASTParserClang` into `llvm::cast`s. (cherry picked from commit ac19d38)
… structure (llvm#170132) Depends on: * llvm#170249 We keep repeating the boilerplate of creating a `DWARFASTParserClangStub` and `TypeSystemClangHolder` in all the unit-test cases. Lets extract this into a helper to make the tests easier to grok. We actually only need the `DWARFASTParserClangStub` and a `TypeSystemClangHolder` in one of the test cases. For the rest, we can just re-use the typesystem/parser that the `YAMLModuleTester` created. Re-using them makes it more straightforward to write test-cases because we don't need to worry about which TypeSystem which DWARFParser created types into. (cherry picked from commit 7685e1f)
…_TAG_typedef (llvm#170135) Depends on: * llvm#170132 Clang gained the `-gtemplate-alias` not too long ago, which emits C++ alias templates as `DW_TAG_template_alias` (instead of `DW_TAG_typedef`). The main difference is that `DW_TAG_template_alias` has `DW_TAG_template_XXX` children. The flag was not enabled by default because consumers (mainly LLDB) didn't know how to handle it. This patch adds rudimentary support for debugging with `DW_TAG_template_alias`. This patch simply creates the same kind of `TypedefDecl` as we do for `DW_TAG_typedef`. The more complete solution would be to create a `TypeAliasTemplateDecl` and associated `TypeAliasDecl`. But that would require DWARF to carry generic template information, but currently each `DW_TAG_template_alias` represents a concrete instantiation. We could probably hack up some working AST representation that includes the template parameters, but I currently don't see a compelling reason to. All we need is the `DW_AT_name` and the `DW_AT_type` that the typedef refers to. rdar://137499401 (cherry picked from commit 1f35b52)
Author
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clang gained the
-gtemplate-aliasnot too long ago, which emits C++alias templates as
DW_TAG_template_alias(instead ofDW_TAG_typedef). The main difference is thatDW_TAG_template_aliashas
DW_TAG_template_XXXchildren. The flag was not enabled by defaultbecause consumers (mainly LLDB) didn't know how to handle it. This patch
adds rudimentary support for debugging with
DW_TAG_template_alias.This patch simply creates the same kind of
TypedefDeclas we do forDW_TAG_typedef. The more complete solution would be to create aTypeAliasTemplateDecland associatedTypeAliasDecl. But that wouldrequire DWARF to carry generic template information, but currently each
DW_TAG_template_aliasrepresents a concrete instantiation. We couldprobably hack up some working AST representation that includes the
template parameters, but I currently don't see a compelling reason to.
All we need is the
DW_AT_nameand theDW_AT_typethat the typedefrefers to.
rdar://137499401
(cherry picked from commit 1f35b52)