Update react-ui-tree.js#14
Open
dannav wants to merge 3 commits intoswiftcarrot:gh-pagesfrom
dannav:patch-1
Open
Update react-ui-tree.js#14dannav wants to merge 3 commits intoswiftcarrot:gh-pagesfrom dannav:patch-1
dannav wants to merge 3 commits intoswiftcarrot:gh-pagesfrom
dannav:patch-1
Conversation
I don't think this is necessary. I may want to move a node under another if it's collapsed. Also this prevents moving any nodes without children under another in the same tree node.
allow creation of static tree to prevent manipulation of structure if defined
Member
|
Is this the same problem with issue #13 ? |
Author
|
I'm sorry I should have been more explicit. Yes this change allows you to add nodes to leaf nodes so it should fix that user's problem as well. |
Author
|
I've also added a prop to define a tree as static to prevent manipulation if a user just wants to display the structure which would resolve issue #6 |
Member
|
Whats the new feature for this pr? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't think this is necessary. I may want to move a node under another if it's collapsed. Also this prevents moving any nodes without children under another in the same tree node.