Change version to include build time and commit id of libswiftnav - #708
Change version to include build time and commit id of libswiftnav#708rge-exafore wants to merge 1 commit into
Conversation
|
Test PASSed. |
| empty := | ||
| space := $(empty) $(empty) | ||
| GIT_VERSION := $(subst $(space),$(dash),$(GIT_VERSION)) | ||
| $(info $(GIT_VERSION)) |
There was a problem hiding this comment.
Is it a debug statement? Some more information may be?
|
looks good |
|
Looks OK to me, what do the new version string look like? |
4f0a962 to
9d412b4
Compare
|
Test PASSed. |
|
The submodule commit IDs are implicitly captured by the piksi_firmware commit ID. What is the motivation for including the libswiftnav commit ID explicitly? |
|
libswiftnav changes more frequently than other submodules that's why including it explicitly. (But including all submodules' commit ids would be even better.) This ensures that the build can be restored even if submodule pointer wasn't moved or public version of libswiftnav was replaced with private or vice versa. |
5 participants
No description provided.