Group by async_apply - #220
Open
akleeman wants to merge 4 commits into
Open
Conversation
akleeman
force-pushed
the
group_by_async_apply
branch
from
March 27, 2020 22:06
86a9d2b to
e67b895
Compare
Contributor
|
from slack - I applied this on top of the no-copy branch (rebased on top of the async utils) and there was a little problem; the lambda I was using for the mean won't compile anymore: fails with this error: reverting this change (and my one include) makes the lambda compile again. |
akleeman
force-pushed
the
group_by_async_apply
branch
from
March 28, 2020 00:40
e67b895 to
511018d
Compare
Contributor
Author
|
Try again, I think I might have fixed the issue. Basically if you do:
|
akleeman
force-pushed
the
group_by_async_apply
branch
from
March 28, 2020 00:46
511018d to
978fcf7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the
async_applymethods which work on map-like objects which makes it compatible withgroup_by.