Skip to content

Modify the solution to Conflicts on Non-textual Files challenge so that it is more consistent with the intended behavior#1125

Merged
erinmgraham merged 1 commit into
swcarpentry:mainfrom
Zhuminem:patch-1
Jun 18, 2026
Merged

Modify the solution to Conflicts on Non-textual Files challenge so that it is more consistent with the intended behavior#1125
erinmgraham merged 1 commit into
swcarpentry:mainfrom
Zhuminem:patch-1

Conversation

@Zhuminem

Copy link
Copy Markdown
Contributor

When trying to keep both images in this challenge, the original solution suggests using "git mv" for renaming one conflicted image file, but only "mv" for another.

Using "mv" in both cases will be more consistent and still correct, while preventing git from auto-resolving the conflict and barring a "git checkout" navigation to the alternate path -- it happens sometimes.

The original solution should still work in some cases, but the updated solution should work in all cases.

…at is is more consistent in intended behavior

When trying to keep both images in this challenge, the original solution suggests using "git mv" for renaming one conflicted image file, but only "mv" for another.

Using "mv" in both cases will be more consistent and still correct, while preventing git from auto-resolving the conflict and barring a "git checkout" navigation to the alternate path -- it happens sometimes.

The original solution should still work in some cases, but the updated solution should work in all cases.
@github-actions

Copy link
Copy Markdown

🆗 Pre-flight checks passed 😃

This pull request has been checked and contains no modified workflow files, spoofing, or invalid commits.

It should be safe to Approve and Run the workflows that need maintainer approval.

@erinmgraham erinmgraham merged commit fc3f76a into swcarpentry:main Jun 18, 2026
1 check passed
@erinmgraham

Copy link
Copy Markdown
Contributor

Great catch! Thank you for your contribution :-)

github-actions Bot pushed a commit that referenced this pull request Jun 18, 2026
Auto-generated via `{sandpaper}`
Source  : fc3f76a
Branch  : main
Author  : erinmgraham <erin.graham@jcu.edu.au>
Time    : 2026-06-18 01:41:44 +0000
Message : Merge pull request #1125 from Zhuminem/patch-1

Modify the solution to Conflicts on Non-textual Files challenge so that it is more consistent with the intended behavior
github-actions Bot pushed a commit that referenced this pull request Jun 18, 2026
Auto-generated via `{sandpaper}`
Source  : 74ab884
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2026-06-18 01:43:46 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : fc3f76a
Branch  : main
Author  : erinmgraham <erin.graham@jcu.edu.au>
Time    : 2026-06-18 01:41:44 +0000
Message : Merge pull request #1125 from Zhuminem/patch-1

Modify the solution to Conflicts on Non-textual Files challenge so that it is more consistent with the intended behavior
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants