chore(bun): update to 1.3.0, wallet-extensions extraction & deps #1535
+2,698
−1,572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ice-chillios
force-pushed
the
chore/bun.v1.3
branch
from
cc538c7 to
9d25177
Compare
ice-chillios
force-pushed
the
chore/bun.v1.3
branch
from
9d25177 to
c2b1a49
Compare
ice-chillios
force-pushed
the
chore/bun.v1.3
branch
from
c1a5e3c to
cb967fa
Compare
ice-chillios
changed the title
ice-chillios
force-pushed
the
chore/bun.v1.3
branch
from
4bb0036 to
3bffc52
Compare
ice-chillios
force-pushed
the
chore/bun.v1.3
branch
from
cc7f03a to
73c9ea7
Compare
There was a problem hiding this comment.
The scope of the PR seems quite broad. I'd like for us to adopt a more conservative and defensive approach to dependency management.
I'm curious about the motives of the wallet-extensions vs wallets packages.
Let's also plan for the Bun 1.3 upgrade later, in a dedicated PR so we don't create potentially painful situations, when it's more battle-tested and when we have identified a clear motive for upgrading.
| [key in keyof UTXOToolboxes]: UTXOToolboxes[key]; | ||
| }; | ||
|
|
||
| export type UtxoToolboxParams = { |
There was a problem hiding this comment.
won't this change make it so UtxoToolboxParams is no longer exported from toolbox?
packages/wallet-extensions/src/helpers/near-browser-provider.d.ts
Outdated
Show resolved
Hide resolved
|
@olegpetroveth it was merged from past 3 prs, as it's stuck in review. Each of them can be separately reviewed from squash commits |
ice-chillios
force-pushed
the
chore/bun.v1.3
branch
from
9714b73 to
00c5982
Compare
ice-chillios
force-pushed
the
chore/bun.v1.3
branch
from
00c5982 to
10cad2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.