Conversation
Collaborator
Author
|
@heliocastro, as you already contributed some valuable refactoring code, perhaps you're interested in reviewing my proposal for an OO API extension here? I would love to hear your opinion... |
312e2e9 to
cdf57f0
Compare
cdf57f0 to
d6b0e77
Compare
3fd439a to
9be7e16
Compare
9be7e16 to
2bb8394
Compare
Collaborator
Author
|
Agreed with @tngraf to proceed with the MR, open topics before merge:
|
Contributor
|
Just FIY, we're in full mode towards next SW360 release, where we we kicked away liferay and whole authentication methods changed and extended API calls will exist, so some refactoring will be needed on sw360python as well. |
e55c440 to
0464feb
Compare
0464feb to
be8dbe2
Compare
Start a high level API
This allows for easy de-duplication.
be8dbe2 to
a2f8d43
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@tngraf, we discussed about this proposal already Siemens-internal a while ago. I still use and love it in a number of places, especially for interactive API usage, so here's the public PR. :)
Several times, I found myself writing project-specific JSON parsing code (especially to parse
['_embedded']['sw360:releases']and friends). So I started with first basic classes and made some important attributes and especially relations available in an OO fashion.My code tries to be a thin and maintenable extension to the mostly direct API access we have now, only adding OO abstractions where they provide real benefit. To avoid the need to closely follow each SW360 api change, I only make important attributes available, the rest is available as the usual JSON data in the
detailsattribute.Example session:
Main open points: