Conversation
Move some reusable code from project classes to base class.
They now allow an arbitrary number of arguments, so we also don't neet the _no_args variant any more.
Replace have_relative_source_file_path() helper function by a generic have_relative_ext_ref_path() which can be re-used for other tasks. To be sure we do the right thing, also add test cases for absolute and relative paths.
Collaborator
Author
|
@tngraf, let me know what you think - if you don't like some changes, I can rework things as needed. :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During development for #33, I stumbled over some methods I wanted to improve and decided to restructure some others for better re-use or better testability.
I think these commits are ready to be merged if you agree, so we could reduce the patch queue in #33.