Skip to content

Conversation

Rich-Harris
Copy link
Member

We need to rethink how boundaries and batches work in relation to each other, per #16959 (comment). As a starting point, we can get rid of #boundary_async_effects, since separating them out achieves nothing — the distinction is whether the async effect should delay the batch from committing, but that's determined inside the async effect itself, not during traversal, so the only impact of having this array is that the effect runs outside the batch context. But that isn't useful (it doesn't save us from re-running it as necessary), it's just an extra array allocation/iteration.

This will enable further experimentation since we can now guarantee that current_batch exists for all suspendy async effects.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Oct 16, 2025

🦋 Changeset detected

Latest commit: 7c1408d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@16968

@Rich-Harris
Copy link
Member Author

going to self-merge this to make my local diffs slightly less chaotic

@Rich-Harris Rich-Harris merged commit 7d977fa into main Oct 17, 2025
18 checks passed
@Rich-Harris Rich-Harris deleted the remove-boundary-async-effects branch October 17, 2025 01:29
@github-actions github-actions bot mentioned this pull request Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant