Skip to content

Conversation

@phi-bre
Copy link

@phi-bre phi-bre commented Nov 2, 2025

Closes #14832
Closes #14602

  • A query can now be called more than once in a single command and calling .refresh() will re-run the remote function (which IMO is the expected behavior when comparing it to client side .refresh functionality)
    export const getTodos = query(async () => {
      // returns todo list from database
    });
    
    export const addTodo = command(async () => {
      const previousTodos = await getTodos();
    
      // Do something that depends on existing todos
    
      await getTodos().refresh(); // Rerun the query so the data sent via single flight mutation is up to date   
    });
  • Calling await getTodos().refresh() only once in the command will not trigger the function twice (unchanged from current behavior)
  • Adds missing query.batch .set operation that was supposed to exist based on existing typescript types but didn't.
  • At the same time, this PR should prevent non-exported query functions from writing to the refreshes cache but still update the function cache correctly.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot
Copy link

changeset-bot bot commented Nov 2, 2025

🦋 Changeset detected

Latest commit: ad22001

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Single flight mutation responds with stale data if query has been used inside command already query.batch.set is not a function

1 participant