Update nodejs package attr to fit https://github.com/NixOS/nixpkgs/pull/199835 #310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperSandro2000
force-pushed
the
normalise-nodejs
branch
from
e0019c4 to
3b63e73
Compare
TSRBerry
reviewed
Jun 19, 2023
TSRBerry
left a comment
TSRBerry
left a comment
There was a problem hiding this comment.
Lgtm, just think the default version should be updated now.
| var lockJSON; | ||
| var registries = []; | ||
| var nodePackage = "nodejs-14_x"; | ||
| var nodePackage = "nodejs_14"; |
There was a problem hiding this comment.
Suggested change
| var nodePackage = "nodejs_14"; | |
| var nodePackage = "nodejs_18"; |
Current node LTS version is v18, I'd prefer to use that as the default.
(I realize it might not have been the current LTS version at the time this PR was created.)
| {pkgs ? import <nixpkgs> { | ||
| inherit system; | ||
| }, system ? builtins.currentSystem, nodejs ? pkgs."nodejs-14_x"}: | ||
| }, system ? builtins.currentSystem, nodejs ? pkgs."nodejs_14"}: |
There was a problem hiding this comment.
Suggested change
| }, system ? builtins.currentSystem, nodejs ? pkgs."nodejs_14"}: | |
| }, system ? builtins.currentSystem, nodejs ? pkgs."nodejs_18"}: |
Same reason as above.
Author
|
The point of this PR was not to bump the LTS version but to resolve the usage of aliases created through the rename of the node packages. I am sure bumping the node LTS versions has further impact which I currently lack the motivation to deal with. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a none backwards compatible change that is required after NixOS/nixpkgs#199835