Skip to content

Handle DATE() parameters the same as excel does. #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stevebroshar wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Handle DATE() parameters the same as excel does. #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/date-time.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,9 +70,11 @@ exports.DATE = function(year, month, day) {
if (utils.anyIsError(year, month, day)) {
return error.value;
}
if (year < 0 || month < 0 || day < 0) {
if (year < 0 || year > 9999) {
return error.num;
}
if (year < 1900)
year += 1900;
var date = new Date(year, month - 1, day);
return date;
};
Expand Down
42 changes: 34 additions & 8 deletions test/date-time.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,40 @@ var dateTime = require('../lib/date-time');
require('should');

suite('Date & Time', function() {
test('DATE', function() {
var date = dateTime.DATE(1900, 1, 1);
date.getFullYear().should.equal(1900);
date.getMonth().should.equal(1 - 1);
date.getDay().should.equal(1);

dateTime.DATE(1900, 1, -1).should.equal(error.num);
dateTime.DATE('invalid').should.equal(error.value);
suite('DATE', function (){
test('returns Date for year, month, day', function(){
var date = dateTime.DATE(1900, 1, 1);
date.getFullYear().should.equal(1900);
date.getMonth().should.equal(1 - 1);
date.getDay().should.equal(1);
});
test('uses year as is for 1900 to 9999', function() {
dateTime.DATE(1900, 2, 2).getFullYear().should.equal(1900);
dateTime.DATE(9999, 2, 2).getFullYear().should.equal(9999);
});
test('adds 1900 to year for 0 to 1899', function() {
dateTime.DATE(0, 2, 2).getFullYear().should.equal(1900);
dateTime.DATE(1899, 2, 2).getFullYear().should.equal(3799);
});
test('returns num error for year <0 or >9999', function() {
dateTime.DATE(-1, 2, 2).should.equal(error.num);
dateTime.DATE(10000, 2, 2).should.equal(error.num);
});
test('adds months >12', function() {
dateTime.DATE(2008, 14, 2).should.eql(new Date(2009, 1, 2));
});
test('subtracts months <0', function() {
dateTime.DATE(2008, -3, 2).should.eql(new Date(2007, 8, 2));
});
test('adds days > month has', function() {
dateTime.DATE(2008, 1, 35).should.eql(new Date(2008, 1, 4));
});
test('subtracts days <0', function() {
dateTime.DATE(2008, 1, -15).should.eql(new Date(2007, 11, 16));
});
test('returns value error for string', function(){
dateTime.DATE('invalid').should.equal(error.value);
});
});

test('DATEVALUE', function() {
Expand Down