Add Pylint GitHub action #154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition to checking for "code quality" (e.g., coding conventions), Pylint can find logical (e.g., calling methods with an incorrect number of arguments) errors. This can help us ensure that the code in the master branch remains in a working state.
rnowling-memphis
requested review from
idanasulin2706 and
shohamroditimemphis
as code owners
|
Note that this is failing right now because of all of the Pylint problems. I recommend that as contributors touch files, they attempt to clean up the Pylint failures in those files. Many of the issues should be something that can be resolved quickly. In cases where we disagree with Pylint, we can add a configuration file that excludes those checks. |
Install the Memphis.py library so that we can grab the dependencies to avoid import errors
|
Pylint was indicating that it couldn't import Memphis.py's dependencies. I added the installation of the Memphis.py library as one of the setup steps. This prevents that error. |
|
Thanks @rnowling-memphis, let's start working with it and make changes accordingly. |
idanasulin2706
approved these changes
May 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to checking for "code quality" (e.g., coding conventions), Pylint can find logical (e.g., calling methods with an incorrect number of arguments) errors. This can help us ensure that the code in the master branch remains in a working state.