fix: Align weekly schedules with week boundary - #6984
Open
usernamenenad wants to merge 3 commits into
Open
Conversation
Weekly schedules can skip selected weekdays that occur before the setup\nday. Start each search at the target week boundary so all configured\nweekdays remain eligible. Signed-off-by: usernamenenad <radovic.nenad158@gmail.com>
Contributor
|
👋 Commands for maintainers:
|
Contributor
|
Maintainers: comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Start weekly schedule searches at the target week boundary. This change keeps
every selected weekday eligible, including weekdays that occur before the day
when the schedule is set up.
Use calendar-day arithmetic so the calculation remains safe across time
changes.
Fixes #6983.
Test plan
make test PKG_TEST_PACKAGES=./pkg/triggers/schedule.make format.go.make lint.make check.build.app.make test.