Skip to content

'backtracking-3'#1068

Open
melvinmilkiyas wants to merge 1 commit intosuper30admin:masterfrom
melvinmilkiyas:master
Open

'backtracking-3'#1068
melvinmilkiyas wants to merge 1 commit intosuper30admin:masterfrom
melvinmilkiyas:master

Conversation

@melvinmilkiyas
Copy link

No description provided.

@super30admin
Copy link
Owner

Strengths:

  • The student demonstrates a good understanding of backtracking and recursion.
  • The code is well-commented and easy to follow.
  • The time and space complexity analyses are accurate.

Areas for Improvement:

  • In the N-Queens solution, initializing the board with None could be confusing. Using False would be more intuitive since the board is boolean.
  • The helper function in N-Queens returns True when a solution is found, but this return value is not used. The function could be made void since the result is stored in self.result.
  • In the Word Search solution, the direc variable could be defined as a class constant (uppercase) to indicate it's a constant value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants