fix(postgrest): fix execute type definition #1262
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fix #1260 by moving
.explain
to a class that returns a different type, and removing the necessity to have the branching in the main object. In order to keep the same behavior, if the user requests for aformat="json"
, it will correctly pick up the inferred type of the response asAPIResponse
, while a barebonesexplain()
should return a str, corresponding to the text of the response.I've also added overloads for
mypy
to correctly differentiate between these different cases when the format is known.Additional context
There's an additional
.csv
method inBaseRPCRequestBuilder
that I'm not sure makes sense to exist.