chore: improve types for functions and cookies #101
+36
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mandarini
force-pushed
the
fix/improve-param-typing
branch
3 times, most recently
from
3579fd3 to
2e73a11
Compare
Contributor
|
@caseybaggz thank you very much for your PR. Unfortunately the tests are failing. Do you want to take a look? |
mandarini
force-pushed
the
fix/improve-param-typing
branch
from
2e73a11 to
b5a7248
Compare
Author
|
@mandarini Yeah, no problem. This might not be an issue anymore since it's so old? If it's not I'll close it ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This PR introduces improved typing which fixes Typescript errors that occur in certain IDEs from the latest release.
What is the current behavior?
When upgrading to 0.6.1 certain TS environments will produce type errors due to confusion with the types. For example, in my current project using SSR went from 0 type errors to about 21 all connected to the
createServerClientfunction.What is the new behavior?
This change both fixes and improves the developer experience for typing in general by simplifying the types in a way that will not confuse Typescript while providing the deprecation notices in the correct locations for developers to easily understand how to migrate which part of the code.
Additional context
n/a