Skip to content

auto cleanup ts from test on drop #628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2025
+13 −5
Merged

auto cleanup ts from test on drop #628

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions crates/base/src/runtime/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2329,7 +2329,6 @@ extern "C" fn mem_check_gc_prologue_callback_fn(
#[cfg(test)]
mod test {
use std::collections::HashMap;
use std::fs::File;
use std::io::Write;
use std::marker::PhantomData;
use std::path::Path;
Expand Down Expand Up @@ -2361,6 +2360,7 @@ mod test {
use serde::de::DeserializeOwned;
use serde::Serialize;
use serial_test::serial;
use tempfile::Builder;
use tokio::sync::mpsc;
use tokio::time::timeout;

Expand Down Expand Up @@ -2593,11 +2593,18 @@ mod test {
#[allow(clippy::arc_with_non_send_sync)]
async fn test_eszip_with_source_file() {
let (worker_pool_tx, _) = mpsc::unbounded_channel::<UserWorkerMsgs>();
let mut file = File::create("./test_cases/eszip-source-test.ts").unwrap();
file.write_all(b"import isEven from \"npm:is-even\"; globalThis.isTenEven = isEven(9);")
let mut temp_file = Builder::new()
.prefix("eszip-source-test")
.suffix(".ts")
.tempfile_in("./test_cases")
.unwrap();
temp_file
.write_all(
b"import isEven from \"npm:is-even\"; globalThis.isTenEven = isEven(9);",
)
.unwrap();

let path_buf = PathBuf::from("./test_cases/eszip-source-test.ts");
let path_buf = temp_file.path().to_path_buf();
let mut emitter_factory = EmitterFactory::new();

emitter_factory.set_deno_options(
Expand All @@ -2618,7 +2625,8 @@ mod test {
.await
.unwrap();

std::fs::remove_file("./test_cases/eszip-source-test.ts").unwrap();
let temp_path = temp_file.into_temp_path();
temp_path.close().unwrap();

let eszip_code = bin_eszip.into_bytes();
let runtime = DenoRuntime::<()>::new(
Expand Down
Loading