🩹(frontend) avoid waiting room requests without room id#1259
Open
merahul22 wants to merge 3 commits intosuitenumerique:mainfrom
Open
🩹(frontend) avoid waiting room requests without room id#1259merahul22 wants to merge 3 commits intosuitenumerique:mainfrom
merahul22 wants to merge 3 commits intosuitenumerique:mainfrom
Conversation
Use canonical documentation routes and add a regression test.
Guard waiting room API calls until room data is available.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guard waiting room API calls until room data is available.
Purpose
The waiting room flow could build API requests before the room data was loaded by falling back to an empty string for
roomId. This could lead to malformed requests such as/rooms//waiting-participants/or/rooms//enter/, and made the loading state harder to reason about.Proposal
Stop using an empty string fallback for the room id, only enable the waiting room query when a real room id is available, and fail fast in waiting room API helpers when the room id is missing.
roomIdis availableroomId