Evict from cache #190
Open
Evict from cache #190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalabukdima
requested changes
Jan 26, 2026
| fn on_dial_failure(&mut self, err: DialFailure) -> Option<TToSwarm<Self>> { | ||
| log::debug!("Dial failure: {err:?}"); | ||
| match err.error { | ||
| libp2p::swarm::DialError::WrongPeerId { obtained: _, address: _ } | |
| None => log::error!("Closed connection not established before"), | ||
| } | ||
| self.evict_from_cache(peer_id); | ||
| log::debug!("Disconnect: {conn:?}"); |
Collaborator
There was a problem hiding this comment.
Is this left intentionally? If yes, can we have a clearer message?
| libp2p::swarm::DialError::WrongPeerId { obtained: _, address: _ } | | ||
| libp2p::swarm::DialError::Transport(_) => { | ||
| if let Some(peer_id) = err.peer_id { | ||
| self.evict_from_cache(peer_id); |
Collaborator
There was a problem hiding this comment.
Swarm events are also sent to each inner behaviour I believe. Let's handle these events directly in the AddressCache behaviour to keep BaseBehaviour as simple as possible.
In case of Kademlia you have to bridge them like this because behaviours don't communicate with each other. But each behaviour communicates with the Swarm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.