Skip to content

Fix PEP440Version.is_final for post releases #1717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
deathaxe wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix PEP440Version.is_final for post releases #1717

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package_control/pep440.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,7 @@ def local(self):
@property
def is_final(self):
"""Version represents a final release."""
return self._tup[2][0][0] == 0
return self._tup[2][0][0] >= 0

@property
def is_dev(self):
Expand Down
21 changes: 21 additions & 0 deletions package_control/tests/test_pep440_version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,3 +309,24 @@ def not_equal(self, a, b):
va = PEP440Version(a)
vb = PEP440Version(b)
self.assertNotEqual(va, vb)

@data(
(
("1.0dev", False),
("1.0a1", False),
("1.0a1.post1", False),
("1.0b1", False),
("1.0b1.post1", False),
("1.0rc", False),
("1.0rc.post1", False),
("1.0rc1", False),
("1.0rc1.post1", False),
("1.0-alpha", False),
("1.0rc1.post1", False),
("1.0", True),
("1.0.post", True),
("1.0.post1", True),
)
)
def is_final(self, ver, result):
self.assertEqual(result, PEP440Version(ver).is_final)