Fix public events API #1715
Open
Fix public events API #1715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python 3.13 plugin_host of ST4201+ does no longer support `ZipLoader`. This commit therefore refactors public `package_control` module to use only built-in import mechanisms if possible and fallback to `ZipLoader` only, if a python 3.3 plugin needs to load `events` module from Package Control.sublime-package running on foreign python 3.8 or 3.13 host. With this change behavior is equal on all plugin_hosts. Only `events` module is exported as this is the only module intended to be public.
Remove manipulation of `__spec__.origin` as it is the counter part of `__file__` but not `__package__`. `__spec__.parent` is derived from `__spec__.name` and doesn't need to be set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.13 plugin_host of ST4201+ does no longer support
ZipLoaderin favor of PEP451 compliant approach.This commit therefore refactors public
package_controlmodule to use only built-in import mechanisms, if possible and fallback toZipLoaderonly, if a python 3.3 plugin needs to loadeventsmodule from Package Control.sublime-package running on foreign python 3.8 or 3.13 host.With this change behavior is equal on all plugin_hosts. Only
eventsmodule is exported as this is the only module intended to be public.