feat(distance): add na_comp option aligned with baseR dist behavior for NA handling - #95
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, when
na_rm = true, the distance calculation would simply skipNA/NaNdimensionsand sum over the remaining valid dimensions. This creates a systematic bias: pairs with more missing
values would artificially appear "closer" than they truly are, simply because fewer dimensions
contributed to the total distance.
This behavior is inconsistent with base R's
dist()function, which applies proportional scaling when computing (Euclidean, Manhattan, Canberra or Minkowski) distances with missing values. This inconsistency can lead to:Changes
na_compparameter to Euclidean and Manhattan distance functions in C++ backendna_comp = trueandna_rm = true, the computed distance sum is scaled up proportionally:adjusted_distance = raw_distance * (total_dims / valid_dims)