Fix Stream Error Handling in Strophe v3.0.1

[jaganvarun059]

Issue Summary:

1. In Strophe.js version 3.0.1, the Strophe.error method is unable to retrieve and process the stream error details.

2. Currently, error details are only logged to the console instead of being handled.

3. Previously, custom error handling could be implemented as follows:

Strophe.error = (errorMsg: string) => {
    // Custom error handling code
};

Fix Details:

1. A call to Strophe.error(errorString) has been added in the _checkStreamError method immediately after logging the error to the console.
2. This change enables the Strophe.error method override to capture stream error details, allowing custom error handling to function as expected.

Testing:

Verified that Strophe.error successfully captures and processes stream error details with the custom error handling code.

[jcbrand]

Thanks for the PR. I understand the problem that you have, but this is not a proper fix.

The Strophe object isn't imported into this file (and shouldn't be to avoid circular dependencies) and you're relying on Strophe being a global here, which is not a guarantee.

For a proper fix, we'll need calls to log.error to somehow be surfaced towards the Strophe object so that they can be overridden or intercepted via Strophe.error.

I'm not sure right now what the right solution will be. Maybe the right solution is to just throw and event inside log.error (and log.info etc.) which is caught by the Strophe object.

[jaganvarun059]

Hi @jcbrand ,

Thanks for the update.

Could you please share the fix for this issue or provide details on how to resolve it?

[jcbrand]

As I mentioned above:

I'm not sure right now what the right solution will be.