Add request_id to downstream_id mapping in translator - #76
Merged
GitGab19 merged 3 commits intoNov 13, 2025
Merged
Conversation
bit-aloo
force-pushed
the
2025-11-06-add-request-id-to-downstream-id-mapping
branch
from
November 6, 2025 16:41
53a1b43 to
c912b40
Compare
bit-aloo
changed the title
plebhash
reviewed
Nov 6, 2025
GitGab19
reviewed
Nov 11, 2025
bit-aloo
force-pushed
the
2025-11-06-add-request-id-to-downstream-id-mapping
branch
from
November 11, 2025 16:34
a1cb581 to
5efa4d2
Compare
GitGab19
approved these changes
Nov 11, 2025
bit-aloo
force-pushed
the
2025-11-06-add-request-id-to-downstream-id-mapping
branch
from
November 11, 2025 17:03
5efa4d2 to
e774157
Compare
plebhash
approved these changes
Nov 12, 2025
bit-aloo
force-pushed
the
2025-11-06-add-request-id-to-downstream-id-mapping
branch
from
November 13, 2025 15:44
e774157 to
5fc722d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the translator, when opening a channel, we were previously assigning the downstream_id to be the same as the message’s request_id. This was a bit hacky and also limited the number of downstreams to a u32 range (which is large, but still an unnecessary constraint). To address this, we’ve introduced a mapping between request_id and downstream_id, which exists only for the duration of the request’s lifetime on the upstream.