Refactor role utils - #73
Merged
plebhash merged 21 commits intoNov 13, 2025
Merged
Conversation
Member
Author
bit-aloo
force-pushed
the
2025-11-06-refactor-role-utils
branch
from
November 6, 2025 09:53
25b8843 to
bff821b
Compare
GitGab19
reviewed
Nov 11, 2025
GitGab19
left a comment
GitGab19
left a comment
Member
There was a problem hiding this comment.
Overall LGTM.
Just left a couple of minor things.
bit-aloo
force-pushed
the
2025-11-06-refactor-role-utils
branch
from
November 11, 2025 16:57
000382d to
7892e88
Compare
2. Update docs in stratum-apps/utils 3. Fix hashrate type SharesPerMinute to Hashrate
bit-aloo
force-pushed
the
2025-11-06-refactor-role-utils
branch
from
November 12, 2025 11:38
7892e88 to
b4e1ca3
Compare
GitGab19
approved these changes
Nov 12, 2025
plebhash
approved these changes
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves most of the common and repetitive utils method spread across all the roles to stratum-apps utils module, and improve the type decoration for the roles as well.