remove unwrap from sv1_api::Subscribe::TryFrom#2198
Merged
plebhash merged 1 commit intoJun 16, 2026
Conversation
lucasbalieiro
force-pushed
the
remove-panic-subscribe-tryfrom
branch
from
e097039 to
dbe5d19
Compare
lucasbalieiro
force-pushed
the
remove-panic-subscribe-tryfrom
branch
from
dbe5d19 to
15f5922
Compare
GitGab19
approved these changes
Jun 16, 2026
lucasbalieiro
force-pushed
the
remove-panic-subscribe-tryfrom
branch
from
15f5922 to
2452052
Compare
plebhash
approved these changes
Jun 16, 2026
Collaborator
Author
|
I've rebased and the CI failures seems unrelated to the changes on this PR |
Member
maybe it was executed in a limbo state (after #2190 but before companion stratum-mining/sv2-apps#554 were merged) seems ok now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2197