Simplify the way that signatures are collected#283
Simplify the way that signatures are collected#283quantumagi wants to merge 14 commits intostratisproject:masterfrom
Conversation
| @@ -0,0 +1,12 @@ | |||
| namespace Stratis.FederatedPeg.Features.FederationGateway.Interfaces | |||
| { | |||
| public interface ISignatureProvider | |||
There was a problem hiding this comment.
Please describe the purpose and behaviour of this class in details, its clear it provides signatures but from who and how are the keys provided?
There was a problem hiding this comment.
The keys are provided by the API call that activates federation. The purpose of the class is in the associated issue. I will add the detail to the class.
|
@quantumagi please describe again the intention behind this change. One thing I don't get here is why do you need to pass signature information between the main and sidechain nodes (the two nodes connect to each other via api), signature material is passed around int he p2p payloads. |
|
@dangershony, let's keep this PR on hold until after the release. There is no intention to pass signatures between main and sidechain nodes. The plan is to replace the P2P calls with API calls (or wait for the P2P results) to support the following simplified synchronous workflow: e.g. a new
This way there is no need to reserve UTXO's in the current way. We simply build, sign and broadcast in a single step. |
bokobza
left a comment
There was a problem hiding this comment.
Locking so it doesn't go in by mistake.
See #281