fix(browser): set event loop on calling thread before nest_asyncio.apply#454
Open
Hweinstock wants to merge 1 commit intostrands-agents:mainfrom
Open
fix(browser): set event loop on calling thread before nest_asyncio.apply#454Hweinstock wants to merge 1 commit intostrands-agents:mainfrom
Hweinstock wants to merge 1 commit intostrands-agents:mainfrom
Conversation
82102bb to
4a3e2b3
Compare
4a3e2b3 to
9379ff6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix a bug in the browser tool that causes it to fail when invoked async. See issue for more information.
The solution is to verify that the event loop is set on the thread that executes the browser tool so that it doesn't matter what thread executes the tool.
Related Issues
Documentation PR
N/A
Type of Change
Bug fix
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
I ran
hatch run prepareAdded a unit test to simulate the scenario.
Patched the import in agent code using browser, and confirmed it works e2e.
patch code used:
which is effectively the underlying implementation.
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.