Skip to content

fix: enable optional parameters in use_aws to prevent KeyError #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jwliu36 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: enable optional parameters in use_aws to prevent KeyError #449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/strands_tools/use_aws.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,6 @@ def get_available_operations(service_name: str) -> List[str]:
"region",
"service_name",
"operation_name",
"parameters",
"label",
],
}
Expand Down Expand Up @@ -280,7 +279,7 @@ def use_aws(tool: ToolUse, **kwargs: Any) -> ToolResult:

service_name = tool_input["service_name"]
operation_name = tool_input["operation_name"]
parameters = tool_input["parameters"]
parameters = tool_input.get("parameters", {})
region = tool_input.get("region", aws_region)
label = tool_input.get("label", "AWS Operation Details")

Expand Down
18 changes: 18 additions & 0 deletions tests/test_use_aws.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,24 @@ def test_use_aws_direct_success(mock_boto3_client, mock_available_services, mock
assert "test-request-id" in result["content"][0]["text"]


def test_use_aws_without_parameters(mock_boto3_client, mock_available_services, mock_available_operations):
"""Test use_aws when parameters is not provided in the input."""
tool_use = {
"toolUseId": "test-tool-use-id",
"input": {
"service_name": "s3",
"operation_name": "list_buckets",
"region": "us-west-2",
"label": "List S3 Buckets",
},
}

result = use_aws.use_aws(tool=tool_use)

assert result["toolUseId"] == "test-tool-use-id"
assert result["status"] == "success"


def test_use_aws_invalid_service(mock_available_services, mock_available_operations):
"""Test use_aws with an invalid service name."""
tool_use = {
Expand Down
Loading