feat(retrieve): expand document location extraction for all KB source types#366
Open
strands-agent wants to merge 1 commit intostrands-agents:mainfrom
Open
Conversation
… types Add support for all RetrievalResultLocation types from the Bedrock API: - webLocation (WEB) - confluenceLocation (CONFLUENCE) - salesforceLocation (SALESFORCE) - sharePointLocation (SHAREPOINT) - kendraDocumentLocation (KENDRA) - sqlLocation (SQL) Previously only customDocumentLocation and s3Location were handled, which limited usability for knowledge bases built on Kendra or other data sources like Confluence, SharePoint, etc. Added tests for each new location type plus a test for unknown/future location types to ensure graceful handling. Closes strands-agents#364
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Expand the
format_results_for_displayfunction in the retrieve tool to handle allRetrievalResultLocationtypes from the Bedrock Knowledge Base API, not justcustomDocumentLocationands3Location.Changes:
webLocation(WEB)confluenceLocation(CONFLUENCE)salesforceLocation(SALESFORCE)sharePointLocation(SHAREPOINT)kendraDocumentLocation(KENDRA)sqlLocation(SQL)Reference:
https://docs.aws.amazon.com/bedrock/latest/APIReference/API_agent-runtime_RetrievalResultLocation.html
Related Issues
Closes #364
Type of Change
Testing
ruff formatandruff check- no issuesChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.