feat(mappers): add OpenAI Agents OTel session mapper - #365
Conversation
|
@strandly-the-agent Review this PR. Consolidate findings into 1 comment. |
This comment was marked as resolved.
This comment was marked as resolved.
|
@strandly-the-agent Review this PR. Consolidate findings into 1 comment. Accepting the risk of finding 3 because it is difficult to reach. |
This comment was marked as resolved.
This comment was marked as resolved.
e0a31b2 to
9fb48f5
Compare
|
@strandly-the-agent Review this PR. Consolidate any findings into a single comment. |
This comment was marked as resolved.
This comment was marked as resolved.
|
@strandly-the-agent Review this PR. Consolidate any findings into a single comment. The 3 findings found in the last round are theoretical, not realistic. |
This comment was marked as resolved.
This comment was marked as resolved.
|
@strandly-the-agent Review this PR. Consolidate any findings into a single comment. |
This comment was marked as resolved.
This comment was marked as resolved.
|
@strandly-the-agent Review this PR. Consolidate any findings into a single comment. A vendor special-case is acceptable for now and the docstring specifies that the scope name is unrecognized by the other mappers. |
This comment was marked as outdated.
This comment was marked as outdated.
|
@strandly-the-agent Review this PR. Consolidate any findings into a single comment. |
This comment was marked as outdated.
This comment was marked as outdated.
086d053 to
916ece7
Compare
|
@strandly-the-agent Review this PR. Consolidate any findings into a single comment. |
|
Suite is green again — the round-7 🔴 is fixed, and nothing of mine remains open. The amended head applies the five assertion updates (delta is tests-only: +27/-14, source and fixtures untouched) and adds the ✅ Full ledger across the PR: findings 1/2/4 fixed at What I ranSelf-run follow-up — the delta only repairs my round-7 finding. Automated review — solid work for a human to approve, not a gate. |
|
@strandly-the-agent Review this PR. Consolidate any findings into a single comment. I removed the handoff reparenting because handoffs are semantically sibling agents. |
|
No blocking findings. Reviewed the ✅ The reversal, for the ledgerAccepting the semantics: OpenAI Agents handoffs transfer control between peers rather than nesting one agent under another, so parent/child was the wrong encoding — siblings it is. Two knock-on effects worth recording:
⚪ The new test's docstring teaches the wrong root-selection rule
What I ranSelf-run follow-up — the delta is a scoped reversal with its test updated in the same commit. Full ledger: findings 1/2/4 fixed · 5 resolved (now via documented sibling semantics) · 3 risk-accepted · 6–8 moot (code deleted) · vendor special-case accepted · round-5 🟡 and round-7 🔴 fixed. Automated review — solid work for a human to approve, not a gate. |
Description
Add support for OpenAI Agent SDK + OpenLLMetry Traceloop instrumentation to
GenericGenAISessionMapper. This combination supports GenAI conventions with some deviations. The PR handles both Cloudwatch ADOT and in-memory exporter formats. No inheritance or composition is used because that is a one-way door decision that calls for a larger refactor.This PR also fixes parent span ids in
GenericGenAISessionMapperso that they point to converted spans. This preserves the agent-tool scopes when converting from OpenAI Agent traces (or other GenAI traces) to evaluator inputs.Related Issues
#319
Documentation PR
Type of Change
New feature
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce new warnings.
hatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.