Repository navigation
Handle negative disabled tolerances in COBYLA - #660
Open
Sinkleberg wants to merge 1 commit into
Open
Sinkleberg wants to merge 1 commit into
Sinkleberg wants to merge 1 commit into
Conversation
Assisted-by: Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #380. Zero and negative tolerances both disable the coordinate stopping criteria. COBYLA could still use a negative relative tolerance to set its final radius.
On a two-dimensional constant objective with a very small initial step, zero tolerance stopped after 81 evaluations. Negative tolerance reached the 250-evaluation cap. The new regression compares the two runs without assuming a particular evaluation count.
All 89 CTest cases passed on Linux. Across 240 paired inputs, the two ways of disabling tolerances now give identical results.