Repository navigation
Include final AGS trials in the returned optimum - #647
Merged
Merged
Conversation
jschueller
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #603.
AGS evaluates a new trial before checking whether to stop, but only updates the best point at the next iteration. Include the final completed trials before cleanup and optional refinement, so the returned coordinates and objective contain the best result already found.
Add regressions for the evaluation limit, forced stop, a constrained final improvement, and unchanged/constant results.
Tested on Windows/MSVC: 87 CTest cases with Python bindings, 52 cases in a C-only build, installed C/C++ consumers, and 748 independent Python API cases. The reported seven-evaluation example now returns 5.8121756154 instead of 6099.2916696.