Fix initial color flash on map load#183
Open
pierres wants to merge 1 commit intostephanwagner:masterfrom
Open
Conversation
Set --svg-map-country-fill CSS variable on the map wrapper to colorNoData before SVG paths render, so countries start with the correct no-data color instead of the hardcoded CSS fallback. This prevents a visible flash when using custom colorNoData values (e.g. dark themes).
pierres
force-pushed
the
fix/initial-color-flash
branch
from
1a8ad8c to
c312557
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On load, country paths briefly render with the hardcoded CSS fallback color (
#E2E2E2) beforeapplyData()sets the final colors. Combined with thefill 250msCSS transition, this causes a noticeable flash — especially whencolorNoDatadiffers significantly from the default (e.g. dark themes).Solution
Set
--svg-map-country-fillCSS variable on the map wrapper tocolorNoDatabefore SVG paths render. Since the variable cascades to all.svgMap-countryelements, they start with the correct color. Only countries with data smoothly transition to their data color.