SPIKE: Protocol 28 (CAP-0084) - #305
Closed
sisuresh wants to merge 1 commit into
Closed
Conversation
Adds the SC_ADDRESS_TYPE_MUXED_CONTRACT arm to SCAddress with a new
MuxedContract { uint64 id; ContractID contractId; } struct, mirroring
MuxedEd25519Account. Gated behind #ifdef CAP_0084 so it lands in `next`
only until core bumps the max supported protocol.
CAP-0084: stellar/stellar-protocol#1968
Contributor
Author
|
Downstream: regenerated rs-stellar-xdr bindings for this CAP-0084 |
Contributor
Author
|
Downstream (Rust): stellar/rs-stellar-xdr#548 → stellar/rs-soroban-env#1695 (SPIKE: Protocol 28 / CAP-0084). |
This was referenced Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SPIKE: root of the Protocol 28 / CAP-0084 (muxed contract addresses) stack. This repo is the canonical
.xsource — no upstream to cross-link.Changes
Stellar-contract.x: addSC_ADDRESS_TYPE_MUXED_CONTRACTarm +MuxedContract { uint64 id; ContractID contractId; }struct +SCAddressunion case, all gated behind#ifdef CAP_0084(mirrorsMuxedEd25519Account).nextonly;currunchanged until core bumps max protocol.cap_0083retained — no CAPs dropped this protocol.Deferred
curr/nextregen: handled by theGenerateworkflow on merge tomain(not committed here).Verification
make preprocesswith both features →nextexits 0, emits the 2 + 2 tokens; baremake preprocess→currexits 0, 0 tokens.Upstream: none (canonical source).
Downstream (re-pin to this branch head, each opened by its own pass): rs-stellar-xdr → rs-soroban-env → rs-soroban-sdk → stellar-core → go-stellar-sdk → stellar-horizon → stellar-rpc → js-stellar-base → js-stellar-sdk → js-stellar-xdr-json → stellar-laboratory → docker-stellar-core-horizon.