SPIKE: Protocol 28 (CAP-0085)#2154
Draft
sisuresh wants to merge 1 commit into
Draft
Conversation
Lab decodes XDR data-driven via @stellar/stellar-sdk + @stellar/stellar-xdr-json; CAP-0085's new arms (SCV_EXECUTABLE_TAG, CONTRACT_EXECUTABLE_EXTERNAL_REF, ContractExecutableExternalRef) render with no lab source change once those deps carry CAP-0085. Pins @stellar/stellar-sdk (js-stellar-sdk#1525, f5a0f7f7) and @stellar/stellar-xdr-json (js-stellar-xdr-json#60, e1ec7587) to local CAP-0085 tarballs under .p28-tarballs via file: refs. js-stellar-sdk@16 vendors stellar-base internally, so no separate @stellar/stellar-base tarball/override is needed. The @ts-expect-error in TransactionDetails.tsx is kept — the new types still don't expose innerTx() on the fee-bump path (tsc TS2339 without it). pnpm build + lint:ts + lint + test:unit all pass with the pins in place. Adds NEXT_PUBLIC_CUSTOM_{HORIZON_URL,RPC_URL,PASSPHRASE} fallbacks to defaultCustomNetwork for the Quickstart-bundled lab.
|
Preview is available here: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SPIKE: Protocol 28 (CAP-0085) — Externally Managed Contract Executables. Built on the CAP-0085 JS stack.
Changes
@stellar/stellar-sdk→ js-stellar-sdk#1525 (f5a0f7f7) and@stellar/stellar-xdr-json→ js-stellar-xdr-json#60 (e1ec7587) via local.p28-tarballs/file:refs.SCV_EXECUTABLE_TAG,CONTRACT_EXECUTABLE_EXTERNAL_REF,ContractExecutableExternalRef) render data-driven — no lab source change.sdk@16vendors stellar-base, so no@stellar/stellar-basetarball/override needed.@ts-expect-errorinTransactionDetails.tsx(still needed on the fee-bumpinnerTx()path).NEXT_PUBLIC_CUSTOM_{HORIZON_URL,RPC_URL,PASSPHRASE}fallbacks todefaultCustomNetworkfor the Quickstart-bundled lab.pnpm build+lint:ts+lint+test:unit(145) pass.Deferred
@stellar-expert/contract-wasm-interface-parsernot bumped — tx-render path doesn't use it; external-ref executables in the contract-explorer are a separate follow-up.--no-verify): sdk CJS@noble/hashesERR_REQUIRE_ESMbreaks Playwright collection only, not build/lint/unit. Re-check on productionize.Upstream
Stays draft for the run.