Show saved contracts in address/contract type dropdown#2130
Open
jeesunikim wants to merge 3 commits into
Open
Conversation
|
Preview is available here: |
Add opt-in includeContracts prop to SignerSelector so the JsonSchema address field lists saved contracts alongside saved keypairs. Contracts only surface in public mode; signing/source-account contexts are unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Preview is available here: |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds saved contracts to address and contract-ID selectors across smart-contract workflows.
Changes:
- Replaces
SignerSelectorwith multi-modeAddressSelector. - Adds saved-contract selection and expanded E2E coverage.
- Updates selector/footer styling and generated network limits.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
tests/e2e/signerSelector.test.ts |
Removes superseded tests. |
tests/e2e/addressSelector.test.ts |
Tests account and contract selection modes. |
src/styles/globals.scss |
Positions renamed/new selector wrappers. |
src/constants/networkLimits.ts |
Refreshes generated network values. |
src/components/TransactionFlowFooter/styles.scss |
Raises sticky footer stacking order. |
src/components/SourceAccountPicker.tsx |
Migrates to AddressSelector. |
src/components/SmartContractJsonSchema/renderPrimitivesType.tsx |
Offers contracts for Soroban addresses. |
src/components/SignerSelector/index.tsx |
Removes replaced selector. |
src/components/FormElements/PubKeyPickerWithSignerSelector.tsx |
Migrates public-key selection. |
src/components/FormElements/MultiPicker.tsx |
Migrates secret-key selection. |
src/components/FormElements/FetchContractMethodPickerWithQuery.tsx |
Adds saved contract-ID selection. |
src/components/ContractSelector/index.tsx |
Adds dropdown icon. |
src/components/AddressSelector/styles.scss |
Renames and extends selector styling. |
src/components/AddressSelector/index.tsx |
Implements multi-mode address selection. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jeesunikim
changed the title
|
Preview is available here: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SignerSelectortoAddressSelectorto accommodate contract addressmodetoAddressSelector.ScAddressdisplays both saved contract and public key.contractdisplays only saved contract address.Screenshots: