-
Notifications
You must be signed in to change notification settings - Fork 536
ingest: Update ingestion library to be able to read hot archive bucket list #5827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for reading evicted entries from the hot archive bucket list to the ingestion library. The changes enable CAP-0076 use cases that require examining hot archive bucket lists.
Key changes:
- Added
NewHotArchiveReaderfunction to create a reader for hot archive bucket lists - Refactored bucket reading logic to support both live and hot archive bucket list types
- Added example script demonstrating usage for finding expiring SAC balances
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
ingest/checkpoint_change_reader.go |
Core implementation for hot archive bucket list support |
ingest/checkpoint_change_reader_test.go |
Updated test calls to use new readBucketRecord method signature |
ingest/tutorial/expiring-sac-balances/main.go |
Example script showing how to find expiring SAC balances using both live and hot archive readers |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
06e750d to
989e83f
Compare
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
CHANGELOG.mdwithin the component folder structure. For example, if I changed horizon, then I updated (services/horizon/CHANGELOG.md. I add a new line item describing the change and reference to this PR. If I don't update a CHANGELOG, I acknowledge this PR's change may not be mentioned in future release notes.semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Add an iterator to the ingestion library which enumerates over evicted entries in the hot archive bucket list.
Also, add an example script which makes use of that iterator to find evicted and soon to be archived contract balances.
Why
CAP-0076 has demonstrated a case where it is useful to examine the hot archive bucket list. We should add this functionality to the ingestion library.
Known limitations
[N/A]