feat(api): expose Date CORS response header for clock skew offset (#147) - #149
Open
namdamdoi68-oss wants to merge 1 commit into
Open
feat(api): expose Date CORS response header for clock skew offset (#147)#149namdamdoi68-oss wants to merge 1 commit into
namdamdoi68-oss wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Exposes the HTTP Date header to CORS clients for server clock-offset calculation.
Changes:
- Adds
DatetoAccess-Control-Expose-Headers. - Tests the updated CORS response headers.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
internal/api/middleware/header.go |
Exposes the Date response header. |
internal/api/middleware/middleware_test.go |
Verifies CORS headers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ellar#147) Signed-off-by: namdamdoi68-oss <namdamdoi68@gmail.com>
namdamdoi68-oss
force-pushed
the
feat/expose-date-cors-header
branch
from
August 2, 2026 02:41
62626d0 to
d449b49
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposes the Date response header in CORS middleware to allow clients to calculate server clock offset and correct wall clock skew. Fixes #147.