Add peripheralIsReady support for writes without response#251
Open
markohara wants to merge 1 commit intosteamclock:masterfrom
Open
Add peripheralIsReady support for writes without response#251markohara wants to merge 1 commit intosteamclock:masterfrom
markohara wants to merge 1 commit intosteamclock:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #250:
Summary of Problem:
The current solution assumes that write events without a response can automatically be processed however this isn't the case. If we have a large volume of writes without a response the will out grow the Core Bluetooth buffer if they are all processed immediately.
Proposed Solution:
To mitigate against this issue apple have introduce the peripheralIsReady toSendWriteWithoutResponse delegate method. My proposed solution uses this method to determine when the write should be processed. I have introduced a new event type and pass it to the handler when the peripheralIsReady delegate method is called