proxy: refactor #3709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

tersec merged 20 commits into master from proxy-frontend

Oct 6, 2025

Contributor

chirag-parmar commented Sep 24, 2025

Verified proxy consists fo two components the verifying algorithms and the proxy. This PR logically splits the verification engine from the proxy. The proxy is further broken down into seperate client and server implementations that connect to the verification engine as backend and frontend resp.

chirag-parmar force-pushed the proxy-frontend branch from 2a1cf98 to 281e715 Compare

September 24, 2025 17:22

chirag-parmar marked this pull request as ready for review

September 24, 2025 19:48

chirag-parmar requested a review from tersec

September 24, 2025 19:48

kdeme reviewed

View reviewed changes

nimbus_verified_proxy/nimbus_verified_proxy_conf.nim Outdated Show resolved Hide resolved

nimbus_verified_proxy/nimbus_verified_proxy_conf.nim Outdated Show resolved Hide resolved

kdeme reviewed

View reviewed changes

nimbus_verified_proxy/engine/accounts.nim Outdated Show resolved Hide resolved

kdeme reviewed

View reviewed changes

nimbus_verified_proxy/engine/receipts.nim Outdated Show resolved Hide resolved

Contributor

tersec commented Sep 26, 2025

I'm not sure why it's not triggering in the CI, but when I make nimbus_verified_proxy locally in this branch, I get:

nimbus-eth1/nimbus_verified_proxy/engine/engine.nim(10, 58) Error: duplicate import of 'header_store'; previous import here: nimbus-eth1/nimbus_verified_proxy/engine/engine.nim(10, 17) [DuplicateModuleImport]

which appears to indeed be the case:

nimbus-eth1/nimbus_verified_proxy/engine/engine.nim

Line 10 in 775421c

import ./types, ./header_store, ./utils, ./rpc_frontend, ./header_store, ./evm

tersec reviewed

View reviewed changes

nimbus_verified_proxy/nimbus_verified_proxy.nim Outdated Show resolved Hide resolved

tersec reviewed

View reviewed changes

nimbus_verified_proxy/engine/engine.nim Show resolved Hide resolved

tersec reviewed

View reviewed changes

nimbus_verified_proxy/nimbus_verified_proxy_conf.nim Outdated Show resolved Hide resolved

tersec reviewed

View reviewed changes

nimbus_verified_proxy/nimbus_verified_proxy.nim Outdated Show resolved Hide resolved

tersec reviewed

View reviewed changes

nimbus_verified_proxy/json_rpc_frontend.nim Outdated Show resolved Hide resolved

tersec reviewed

View reviewed changes

nimbus_verified_proxy/json_rpc_frontend.nim Outdated Show resolved Hide resolved

tersec reviewed

View reviewed changes

nimbus_verified_proxy/json_rpc_frontend.nim Outdated Show resolved Hide resolved

tersec reviewed

View reviewed changes

nimbus_verified_proxy/engine/blocks.nim Show resolved Hide resolved

tersec reviewed

View reviewed changes

nimbus_verified_proxy/engine/utils.nim Outdated Show resolved Hide resolved

tersec reviewed

View reviewed changes

nimbus_verified_proxy/engine/utils.nim Outdated Show resolved Hide resolved

chirag-parmar force-pushed the proxy-frontend branch from 42cd4e8 to 606c8db Compare

September 26, 2025 10:14

chirag-parmar and others added 12 commits

September 26, 2025 16:00


          partial

9e5cf5d


          finally working

a61ac78


          type fix


          builds but segfault

a8be838

fix

dff5893


          works

07dc805


          update tests

f433f08


          fix tests

f1343e0


          format

f1860a7


          lib fix

c7e1e4b


          Update nimbus_verified_proxy/nimbus_verified_proxy_conf.nim

42a750e

Co-authored-by: kdeme <[email protected]>


          review

399122b

chirag-parmar added 5 commits

September 26, 2025 16:00


          async raises


          review

69158cd


          fix test error specifications

e6c3105


          format

1ed4913


          trigger CI

5b3fa62

chirag-parmar force-pushed the proxy-frontend branch from 2835879 to 5b3fa62 Compare

September 26, 2025 10:30

chirag-parmar requested review from kdeme and tersec

September 29, 2025 09:57

chirag-parmar added 2 commits

September 30, 2025 10:14


          Merge branch 'master' into proxy-frontend

27963eb

fix

2ff8b2d

Contributor Author

chirag-parmar commented Oct 3, 2025

@tersec @kdeme are there any other reviews?


          add comments

32db194

tersec merged commit cacde70 into master

18 checks passed

tersec deleted the proxy-frontend branch

October 6, 2025 08:14

chirag-parmar mentioned this pull request

proxy: rest based light client #3782

Merged

3 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet