Throw exception if network is not working - #19
Open
MaurizioK wants to merge 2 commits into
Open
Conversation
MaurizioK
marked this pull request as ready for review
June 25, 2024 12:28
MarcoStatespace
approved these changes
Jun 25, 2024
| if (webRequest.result == UnityWebRequest.Result.ConnectionError) | ||
| { | ||
| Debug.LogError("Error While Sending: " + webRequest.error); | ||
| throw new UnityWebRequestException(webRequest); |
There was a problem hiding this comment.
Would this make the console to crash?
Author
There was a problem hiding this comment.
At line 177 there is the same thing (already there since the dawn of time).
If the flow I've found is the only one possible, then this exception is catched by our GraphQL utility, the good ol' Query_Internal method. Since it's a managed exception it shouldn't make the console crash.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs: