[6.x] Add size prop to FieldsProvider and Textarea #12513
Conversation
|
My guess would be any weird inconsistencies come from the first place i needed a variant and just made it fit that particular case. I'll dig around and see about those borders because I'm with you — I'd much rather them be consistent as a system and override as needed. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| :key="$index" | ||
| :name="name" | ||
| :read-only="isReadOnly" | ||
| :size="fieldsContext.size.value" |
There was a problem hiding this comment.
Bug: Context Access Error in Fieldtype Components
Accessing fieldsContext.size.value in ButtonGroupFieldtype, ToggleFieldtype, and TextareaFieldtype without null checking causes a runtime error. If these components are used outside a FieldsProvider context, fieldsContext is undefined, leading to an error like "Cannot read properties of undefined (reading 'size')".
Additional Locations (2)
| inject: { | ||
| fieldsContext: 'PublishFieldsContext', | ||
| }, |
There was a problem hiding this comment.
Bug: Context Key Mismatch Causes Undefined Error
The inject key 'PublishFieldsContext' doesn't match the 'PublishFields' key used by the FieldsProvider when creating the context. This causes fieldsContext to be undefined, leading to runtime errors when attempting to access fieldsContext.size.value.
Additional Locations (2)
This PR adds a
sizeprop to theFieldsProvidercomponent, which is then passed down to the components that support it by the fieldtypes. This allows you to make an entire set of fieldssmfor example (but only for types that supportsize).It also adds a
sizeprop and variant classes to theTextareacomponent (may need some tweaking).I did notice some inconsistency in border radius on the
xssizes. Button groups and selects are more rounded than text (and now textarea as well). Might be intentional but thought I'd mention it.If you're making a whole set of fields small there's probably an argument for reducing the labels and gaps between fields as well, but I'll leave that up to you. I'm using this in my Miniset addon and can always adjust things there with CSS if necessary.