feat: add macro #179
Open
feat: add macro #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdelabro
requested review from
dan-starkware,
gabrielbosio and
pefontana
as code owners
add typo check to CI
ksew1
reviewed
Nov 6, 2025
maciejka
approved these changes
Nov 7, 2025
gabrielbosio
reviewed
Nov 7, 2025
gabrielbosio
reviewed
Nov 7, 2025
gabrielbosio
reviewed
Nov 7, 2025
crates/felt-macro/src/lib.rs
Outdated
| .. | ||
| }) => Err(Error::new_spanned( | ||
| expr, | ||
| "The `!` logical inversion operator is applicable to the `Felt` type", |
Collaborator
There was a problem hiding this comment.
Why the error message in this case is different than the one from line 209?
Why does this macro only accept the ! operator only with integer variables but doesn't with literals?
Collaborator
Author
There was a problem hiding this comment.
It's a bit more specific, because !42 is a valid rust expression, but is invalid in the context of Felt, and the Not operator doesn't exist in this context.
The second message is about stuff like !"abc" which are not even valid Rust expression.
Collaborator
Author
There was a problem hiding this comment.
to be honest !b'c' is a valid rust expression tho. COz it returns a u8.
So this one could be handled in the first one too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a
felt!macro that allow for easy initialization ofFeltfrom different types