Skip to content

fix: json schema for datetime #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 19, 2025
Merged

fix: json schema for datetime #114

merged 1 commit into from
May 19, 2025

Conversation

@gadomski
Copy link
Member

@gadomski gadomski commented May 19, 2025 •
edited
Loading

What I'm changing

  • Use {"type": "string"} for the OpenAPI docs for datetime, too

How I did it

  • Also added an example

image

@gadomski gadomski self-assigned this May 19, 2025
@gadomski gadomski requested review from jkeifer and philvarner May 19, 2025 16:55
@gadomski gadomski linked an issue May 19, 2025 that may be closed by this pull request
DatetimeInterval Pydantic Model rendered incorrectly in FastAPI Generate Swagger Docs #113
Closed
@gadomski gadomski merged commit 33c205c into main May 19, 2025
4 checks passed
@gadomski gadomski deleted the issues/113-swagger-docs branch May 19, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkeifer jkeifer jkeifer approved these changes

@philvarner philvarner Awaiting requested review from philvarner

Assignees

@gadomski gadomski

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DatetimeInterval Pydantic Model rendered incorrectly in FastAPI Generate Swagger Docs

3 participants

@gadomski @jkeifer