Draft
Conversation
Co-authored-by: stanleyrya <stanleyrya@gmail.com>
|
Cursor Agent can help with this pull request. Just |
Co-authored-by: stanleyrya <stanleyrya@gmail.com>
Co-authored-by: stanleyrya <stanleyrya@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Normalize event dates to UTC for deduplication and fix recurring event generation to correctly handle timezones and monthly patterns.
Event deduplication was failing for recurring events because
startDatewas inconsistent across different parsers (UTC vs. local timezone) and thegetVisibleEventDatesfunction was losing timezone information when generating occurrences. This led to incorrect date keys for deduplication. Additionally, monthly recurring events with "last Saturday" patterns were not generating correct occurrence dates. The changes ensure that timezone information is preserved during recurrence expansion and that all dates are consistently normalized to UTC for deduplication keys.